Commit a2d05fb7 authored Dec 21, 2021 by Yang Yingliang Committed by Bartosz Golaszewski Dec 21, 2021

gpio: sim: add missing fwnode_handle_put() in gpio_sim_probe()



Calling fwnode_handle_put() when break out of device_for_each_child_node(),
or the device node reference will be leakd.

Fixes: 83960fcf4818 ("gpio: sim: new testing module")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

parent 572006bc

drivers/gpio/gpio-sim.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -444,9 +444,11 @@ static int gpio_sim_probe(struct platform_device *pdev)

	device_for_each_child_node(dev, swnode) {		device_for_each_child_node(dev, swnode) {
	ret = gpio_sim_add_bank(swnode, dev);		ret = gpio_sim_add_bank(swnode, dev);
	if (ret)		if (ret) {
			fwnode_handle_put(swnode);
	return ret;		return ret;
	}		}
			}

	return 0;		return 0;
	}		}