Unverified Commit a2cc1568 authored Mar 12, 2021 by Pierre-Louis Bossart Committed by Mark Brown Mar 18, 2021

ASoC: tscs454: remove useless test on PLL disable



cppcheck warning:

sound/soc/codecs/tscs454.c:730:37: style: Same value in both branches
of ternary operator. [duplicateValueTernary]
  val = pll1 ? FV_PLL1CLKEN_DISABLE : FV_PLL2CLKEN_DISABLE;
                                    ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210312182246.5153-24-pierre-louis.bossart@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 39e69cef

sound/soc/codecs/tscs454.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -727,7 +727,12 @@ static int pll_power_event(struct snd_soc_dapm_widget *w,
		if (enable)
		val = pll1 ? FV_PLL1CLKEN_ENABLE : FV_PLL2CLKEN_ENABLE;
		else
		val = pll1 ? FV_PLL1CLKEN_DISABLE : FV_PLL2CLKEN_DISABLE;
		/*
		* FV_PLL1CLKEN_DISABLE and FV_PLL2CLKEN_DISABLE are
		* identical zero vzalues, there is no need to test
		* the PLL index
		*/
		val = FV_PLL1CLKEN_DISABLE;

		ret = snd_soc_component_update_bits(component, R_PLLCTL, msk, val);
		if (ret < 0) {