Commit a2b3fc56 authored by Luke D. Jones's avatar Luke D. Jones Committed by Jialin Zhang
Browse files

HID: asus: Remove check for same LED brightness on set 

mainline inclusion
from mainline-v5.14-rc4
commit 3fdcf7cd
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I6I7U9
CVE: CVE-2023-1079

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3fdcf7cdfc229346d028242e73562704ad644dd0



--------------------------------

Remove the early return on LED brightness set so that any controller
application, daemon, or desktop may set the same brightness at any stage.

This is required because many ASUS ROG keyboards will default to max
brightness on laptop resume if the LEDs were set to off before sleep.

Signed-off-by: default avatarLuke D Jones <luke@ljones.dev>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarYuyao Lin <linyuyao1@huawei.com>
Reviewed-by: default avatarWei Li <liwei391@huawei.com>
Reviewed-by: default avatarWang Weiyang <wangweiyang2@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parent 671384c6

drivers/hid/hid-asus.c

+0 −3
Original line number Diff line number Diff line
@@ -402,9 +402,6 @@ static void asus_kbd_backlight_set(struct led_classdev *led_cdev, 
{

	struct asus_kbd_leds *led = container_of(led_cdev, struct asus_kbd_leds,

						 cdev);

	if (led->brightness == brightness)

		return;



	led->brightness = brightness;

	schedule_work(&led->work);

}