Commit a2b28708 authored by Gong Yuanjun's avatar Gong Yuanjun Committed by Alex Deucher
Browse files

drm/radeon: fix a possible null pointer dereference 



In radeon_fp_native_mode(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.

The failure status of drm_cvt_mode() on the other path is checked too.

Signed-off-by: default avatarGong Yuanjun <ruc_gongyuanjun@163.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 10784fec

drivers/gpu/drm/radeon/radeon_connectors.c

+4 −0
Original line number Diff line number Diff line
@@ -473,6 +473,8 @@ static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encode 
	    native_mode->vdisplay != 0 &&

	    native_mode->clock != 0) {

		mode = drm_mode_duplicate(dev, native_mode);

		if (!mode)

			return NULL;

		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;

		drm_mode_set_name(mode);
@@ -487,6 +489,8 @@ static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encode 
		 * simpler.

		 */

		mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);

		if (!mode)

			return NULL;

		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;

		DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);

	}