Commit a2a5f562 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Jani Nikula
Browse files

drm/i915: Fix ICL MG PHY vswing handling 



The MH PHY vswing table does have all the entries these days. Get
rid of the old hacks in the code which claim otherwise.

This hack was totally bogus anyway. The correct way to handle the
lack of those two entries would have been to declare our max
vswing and pre-emph to both be level 2.

Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Clinton Taylor <clinton.a.taylor@intel.com>
Fixes: 9f7ffa29 ("drm/i915/tc/icl: Update TC vswing tables")
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201207203512.1718-1-ville.syrjala@linux.intel.com


Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
(cherry picked from commit 5ec34647)
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent ef99a60f

drivers/gpu/drm/i915/display/intel_ddi.c

+3 −4
Original line number Diff line number Diff line
@@ -2755,12 +2755,11 @@ static void icl_mg_phy_ddi_vswing_sequence(struct intel_encoder *encoder, 
	u32 val;



	ddi_translations = icl_get_mg_buf_trans(encoder, crtc_state, &n_entries);

	/* The table does not have values for level 3 and level 9. */

	if (level >= n_entries || level == 3 || level == 9) {

	if (level >= n_entries) {

		drm_dbg_kms(&dev_priv->drm,

			    "DDI translation not found for level %d. Using %d instead.",

			    level, n_entries - 2);

		level = n_entries - 2;

			    level, n_entries - 1);

		level = n_entries - 1;

	}



	/* Set MG_TX_LINK_PARAMS cri_use_fs32 to 0. */