Commit a29cc43c authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Tomi Valkeinen
Browse files

drm/omap: drop unused dsi.configure_pins 



The panel-dsi-cm's ddata->pin_config is always NULL, so this
callback is never called. Instead the DSI encoder gets the pin
configuration directly from DT.

Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201215104657.802264-3-tomi.valkeinen@ti.com
parent 12db515b

drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c

+0 −11
Original line number Diff line number Diff line
@@ -68,8 +68,6 @@ struct panel_drv_data { 
	int width_mm;

	int height_mm;



	struct omap_dsi_pin_config pin_config;



	/* runtime variables */

	bool enabled;
@@ -623,15 +621,6 @@ static int dsicm_power_on(struct panel_drv_data *ddata) 
		}

	}



	if (ddata->pin_config.num_pins > 0) {

		r = src->ops->dsi.configure_pins(src, &ddata->pin_config);

		if (r) {

			dev_err(&ddata->pdev->dev,

				"failed to configure DSI pins\n");

			goto err_vddi;

		}

	}



	r = src->ops->dsi.set_config(src, &dsi_config);

	if (r) {

		dev_err(&ddata->pdev->dev, "failed to configure DSI\n");

drivers/gpu/drm/omapdrm/dss/dsi.c

+0 −1
Original line number Diff line number Diff line
@@ -4890,7 +4890,6 @@ static const struct omap_dss_device_ops dsi_ops = { 


		.enable_hs = dsi_vc_enable_hs,



		.configure_pins = dsi_configure_pins,

		.set_config = dsi_set_config,



		.enable_video_output = dsi_enable_video_output,

drivers/gpu/drm/omapdrm/dss/omapdss.h

+0 −2
Original line number Diff line number Diff line
@@ -296,8 +296,6 @@ struct omapdss_dsi_ops { 
	/* bus configuration */

	int (*set_config)(struct omap_dss_device *dssdev,

			const struct omap_dss_dsi_config *cfg);

	int (*configure_pins)(struct omap_dss_device *dssdev,

			const struct omap_dsi_pin_config *pin_cfg);



	void (*enable_hs)(struct omap_dss_device *dssdev, int channel,

			bool enable);