Commit a27648c7 authored Jun 07, 2023 by David Howells Committed by Linus Torvalds Jun 07, 2023

afs: Fix setting of mtime when creating a file/dir/symlink



kafs incorrectly passes a zero mtime (ie. 1st Jan 1970) to the server when
creating a file, dir or symlink because the mtime recorded in the
afs_operation struct gets passed to the server by the marshalling routines,
but the afs_mkdir(), afs_create() and afs_symlink() functions don't set it.

This gets masked if a file or directory is subsequently modified.

Fix this by filling in op->mtime before calling the create op.

Fixes: e49c7b2f ("afs: Build an abstraction around an "operation" concept")
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a4d7d701

fs/afs/dir.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1358,6 +1358,7 @@ static int afs_mkdir(struct mnt_idmap idmap, struct inode dir,
		op->dentry = dentry;
		op->create.mode = S_IFDIR \| mode;
		op->create.reason = afs_edit_dir_for_mkdir;
		op->mtime = current_time(dir);
		op->ops = &afs_mkdir_operation;
		return afs_do_sync_operation(op);
		}
		@@ -1661,6 +1662,7 @@ static int afs_create(struct mnt_idmap idmap, struct inode dir,
		op->dentry = dentry;
		op->create.mode = S_IFREG \| mode;
		op->create.reason = afs_edit_dir_for_create;
		op->mtime = current_time(dir);
		op->ops = &afs_create_operation;
		return afs_do_sync_operation(op);

		@@ -1796,6 +1798,7 @@ static int afs_symlink(struct mnt_idmap idmap, struct inode dir,
		op->ops = &afs_symlink_operation;
		op->create.reason = afs_edit_dir_for_symlink;
		op->create.symlink = content;
		op->mtime = current_time(dir);
		return afs_do_sync_operation(op);

		error: