Commit a2741c58 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/net: don't retry recvmsg() unnecessarily 



If we're doing multishot receives, then we always end up doing two trips
through sock_recvmsg(). For protocols that sanely set msghdr->msg_inq,
then we don't need to waste time picking a new buffer and attempting a
new receive if there's nothing there.

Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7d41bcb7

io_uring/net.c

+9 −1
Original line number Diff line number Diff line
@@ -635,7 +635,15 @@ static inline bool io_recv_finish(struct io_kiocb *req, int *ret, 
		if (io_aux_cqe(req->ctx, issue_flags & IO_URING_F_COMPLETE_DEFER,

			       req->cqe.user_data, *ret, cflags | IORING_CQE_F_MORE, true)) {

			io_recv_prep_retry(req);

			/* Known not-empty or unknown state, retry */

			if (cflags & IORING_CQE_F_SOCK_NONEMPTY ||

			    msg->msg_inq == -1U)

				return false;

			if (issue_flags & IO_URING_F_MULTISHOT)

				*ret = IOU_ISSUE_SKIP_COMPLETE;

			else

				*ret = -EAGAIN;

			return true;

		}

		/* Otherwise stop multishot but use the current result. */

	}