Commit a25f8222 authored by Alexander Lobakin's avatar Alexander Lobakin Committed by David S. Miller
Browse files

flow_dissector: fix byteorder of dissected ICMP ID 



flow_dissector_key_icmp::id is of type u16 (CPU byteorder),
ICMP header has its ID field in network byteorder obviously.
Sparse says:

net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to integer

Convert ID value to CPU byteorder when storing it into
flow_dissector_key_icmp.

Fixes: 5dec597e ("flow_dissector: extract more ICMP information")
Signed-off-by: default avatarAlexander Lobakin <alobakin@pm.me>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50535249

net/core/flow_dissector.c

+1 −1
Original line number Diff line number Diff line
@@ -176,7 +176,7 @@ void skb_flow_get_icmp_tci(const struct sk_buff *skb, 
	 * avoid confusion with packets without such field

	 */

	if (icmp_has_id(ih->type))

		key_icmp->id = ih->un.echo.id ? : 1;

		key_icmp->id = ih->un.echo.id ? ntohs(ih->un.echo.id) : 1;

	else

		key_icmp->id = 0;

}