Commit a2446bc7 authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: TC, Reject rules with drop and modify hdr action 



This kind of action is not supported by firmware and generates a
syndrome.

kernel: mlx5_core 0000:08:00.0: mlx5_cmd_check:777:(pid 102063): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x8708c3)

Fixes: d7e75a32 ("net/mlx5e: Add offloading of E-Switch TC pedit (header re-write) actions")
Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarOz Shlomo <ozsh@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 350d9a82

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+6 −0
Original line number Diff line number Diff line
@@ -3191,6 +3191,12 @@ actions_match_supported(struct mlx5e_priv *priv, 
		return false;

	}



	if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR &&

	    actions & MLX5_FLOW_CONTEXT_ACTION_DROP) {

		NL_SET_ERR_MSG_MOD(extack, "Drop with modify header action is not supported");

		return false;

	}



	if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR &&

	    !modify_header_match_supported(priv, &parse_attr->spec, flow_action,

					   actions, ct_flow, ct_clear, extack))