Commit a2417db3 authored by Li Zhijian's avatar Li Zhijian Committed by Martin K. Petersen
Browse files

scsi: core: Shorten long warning messages 

sdev_printk() will only accept messages up to 128 bytes.

Shorten strings exceeding 128 bytes avoid printing an incomplete sentence
like:

  [  475.156955] sd 9:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical

Link: https://lore.kernel.org/r/20220630024516.1571209-1-lizhijian@fujitsu.com


Suggested-by: default avatarFinn Thain <fthain@linux-m68k.org>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 34bd1dca

drivers/scsi/scsi_error.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -463,14 +463,12 @@ static void scsi_report_sense(struct scsi_device *sdev, 
			evt_type = SDEV_EVT_LUN_CHANGE_REPORTED;

			evt_type = SDEV_EVT_LUN_CHANGE_REPORTED;

			scsi_report_lun_change(sdev);

			scsi_report_lun_change(sdev);

			sdev_printk(KERN_WARNING, sdev,

			sdev_printk(KERN_WARNING, sdev,

				    "Warning! Received an indication that the "

				    "LUN assignments on this target have "

				    "LUN assignments on this target have "

				    "changed. The Linux SCSI layer does not "

				    "changed. The Linux SCSI layer does not "

				    "automatically remap LUN assignments.\n");

				    "automatically remap LUN assignments.\n");

		} else if (sshdr->asc == 0x3f)

		} else if (sshdr->asc == 0x3f)

			sdev_printk(KERN_WARNING, sdev,

			sdev_printk(KERN_WARNING, sdev,

				    "Warning! Received an indication that the "

				    "Operating parameters on this target have "

				    "operating parameters on this target have "

				    "changed. The Linux SCSI layer does not "

				    "changed. The Linux SCSI layer does not "

				    "automatically adjust these parameters.\n");

				    "automatically adjust these parameters.\n");