Unverified Commit a23faea7 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown
Browse files

spi: omap-100k: Fix reference leak to master 



Call spi_master_get() holds the reference count to master device, thus
we need an additional spi_master_put() call to reduce the reference
count, otherwise we will leak a reference to master.

This commit fix it by removing the unnecessary spi_master_get().

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210409082954.2906933-1-weiyongjun1@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a0367549

drivers/spi/spi-omap-100k.c

+3 −3
Original line number Diff line number Diff line
@@ -424,7 +424,7 @@ static int omap1_spi100k_probe(struct platform_device *pdev) 


static int omap1_spi100k_remove(struct platform_device *pdev)

{

	struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));

	struct spi_master *master = platform_get_drvdata(pdev);

	struct omap1_spi100k *spi100k = spi_master_get_devdata(master);



	pm_runtime_disable(&pdev->dev);
@@ -438,7 +438,7 @@ static int omap1_spi100k_remove(struct platform_device *pdev) 
#ifdef CONFIG_PM

static int omap1_spi100k_runtime_suspend(struct device *dev)

{

	struct spi_master *master = spi_master_get(dev_get_drvdata(dev));

	struct spi_master *master = dev_get_drvdata(dev);

	struct omap1_spi100k *spi100k = spi_master_get_devdata(master);



	clk_disable_unprepare(spi100k->ick);
@@ -449,7 +449,7 @@ static int omap1_spi100k_runtime_suspend(struct device *dev) 


static int omap1_spi100k_runtime_resume(struct device *dev)

{

	struct spi_master *master = spi_master_get(dev_get_drvdata(dev));

	struct spi_master *master = dev_get_drvdata(dev);

	struct omap1_spi100k *spi100k = spi_master_get_devdata(master);

	int ret;