Commit a21a0eb5 authored by Aditya Pakki's avatar Aditya Pakki Committed by Mauro Carvalho Chehab
Browse files

media: gspca: Check the return value of write_bridge for timeout 



In po1030_probe(), m5602_write_bridge() can timeout and return an error
value. The fix checks for the return value and propagates upstream
consistent with other usb drivers.

Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 5b711870

drivers/media/usb/gspca/m5602/m5602_po1030.c

+6 −2
Original line number Diff line number Diff line
@@ -158,6 +158,7 @@ static const struct v4l2_ctrl_config po1030_greenbal_cfg = { 


int po1030_probe(struct sd *sd)

{

	int rc = 0;

	u8 dev_id_h = 0, i;

	struct gspca_dev *gspca_dev = (struct gspca_dev *)sd;
@@ -177,11 +178,14 @@ int po1030_probe(struct sd *sd) 
	for (i = 0; i < ARRAY_SIZE(preinit_po1030); i++) {

		u8 data = preinit_po1030[i][2];

		if (preinit_po1030[i][0] == SENSOR)

			m5602_write_sensor(sd,

			rc |= m5602_write_sensor(sd,

				preinit_po1030[i][1], &data, 1);

		else

			m5602_write_bridge(sd, preinit_po1030[i][1], data);

			rc |= m5602_write_bridge(sd, preinit_po1030[i][1],

						data);

	}

	if (rc < 0)

		return rc;



	if (m5602_read_sensor(sd, PO1030_DEVID_H, &dev_id_h, 1))

		return -ENODEV;