Commit a218c438 authored by Sean Anderson's avatar Sean Anderson Committed by Zheng Qixing
Browse files

drm: zynqmp_kms: Unplug DRM device before removal 

stable inclusion
from stable-v6.6.64
commit a17b9afe58c474657449cf87e238b1788200576b
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBEAE5
CVE: CVE-2024-56538

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a17b9afe58c474657449cf87e238b1788200576b

--------------------------------

[ Upstream commit 2e07c88914fc5289c21820b1aa94f058feb38197 ]

Prevent userspace accesses to the DRM device from causing
use-after-frees by unplugging the device before we remove it. This
causes any further userspace accesses to result in an error without
further calls into this driver's internals.

Fixes: d76271d2 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Closes: https://lore.kernel.org/dri-devel/4d8f4c9b-2efb-4774-9a37-2f257f79b2c9@linux.dev/


Signed-off-by: default avatarSean Anderson <sean.anderson@linux.dev>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240809193600.3360015-2-sean.anderson@linux.dev


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZheng Qixing <zhengqixing@huawei.com>
parent 604e996d

drivers/gpu/drm/xlnx/zynqmp_kms.c

+1 −1
Original line number Diff line number Diff line
@@ -533,7 +533,7 @@ void zynqmp_dpsub_drm_cleanup(struct zynqmp_dpsub *dpsub) 
{

	struct drm_device *drm = &dpsub->drm->dev;



	drm_dev_unregister(drm);

	drm_dev_unplug(drm);

	drm_atomic_helper_shutdown(drm);

	drm_encoder_cleanup(&dpsub->drm->encoder);

	drm_kms_helper_poll_fini(drm);