Commit a204ea8c authored Aug 03, 2021 by Tuo Li Committed by Alex Deucher Aug 05, 2021

drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and...

drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()

The varialbe gtt in the function amdgpu_ttm_tt_populate() and
amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context.
Thus the null-pointer checks are redundant and can be dropped.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Tuo Li <islituo@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 11e612a0

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1123,7 +1123,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_device *bdev,
		struct amdgpu_ttm_tt gtt = (void )ttm;

		/* user pages are bound by amdgpu_ttm_tt_pin_userptr() */
		if (gtt && gtt->userptr) {
		if (gtt->userptr) {
		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
		if (!ttm->sg)
		return -ENOMEM;
		@@ -1148,7 +1148,7 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_device *bdev,
		struct amdgpu_ttm_tt gtt = (void )ttm;
		struct amdgpu_device *adev;

		if (gtt && gtt->userptr) {
		if (gtt->userptr) {
		amdgpu_ttm_tt_set_user_pages(ttm, NULL);
		kfree(ttm->sg);
		ttm->sg = NULL;