Commit a1fde923 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: refactor io_close 



A small refactoring shrinking it and making easier to read.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/19b24eed7cd491a0243b50366dd2a23b558e2665.1618101759.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 3f48cf18

fs/io_uring.c

+3 −10
Original line number Diff line number Diff line
@@ -4181,11 +4181,9 @@ static int io_close(struct io_kiocb *req, unsigned int issue_flags) 
	struct files_struct *files = current->files;

	struct io_close *close = &req->close;

	struct fdtable *fdt;

	struct file *file;

	int ret;

	struct file *file = NULL;

	int ret = -EBADF;



	file = NULL;

	ret = -EBADF;

	spin_lock(&files->file_lock);

	fdt = files_fdtable(files);

	if (close->fd >= fdt->max_fds) {
@@ -4193,12 +4191,7 @@ static int io_close(struct io_kiocb *req, unsigned int issue_flags) 
		goto err;

	}

	file = fdt->fd[close->fd];

	if (!file) {

		spin_unlock(&files->file_lock);

		goto err;

	}



	if (file->f_op == &io_uring_fops) {

	if (!file || file->f_op == &io_uring_fops) {

		spin_unlock(&files->file_lock);

		file = NULL;

		goto err;