Commit a1f3486b authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: iscsi: Move pool freeing 

This doesn't fix any bugs, but it makes more sense to free the pool after
we have removed the session. At that time we know nothing is touching any
of the session fields, because all devices have been removed and scans are
stopped.

Link: https://lore.kernel.org/r/20210525181821.7617-19-michael.christie@oracle.com


Reviewed-by: default avatarLee Duncan <lduncan@suse.com>
Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 99b06033

drivers/scsi/libiscsi.c

+1 −2
Original line number Diff line number Diff line
@@ -3001,10 +3001,9 @@ void iscsi_session_teardown(struct iscsi_cls_session *cls_session) 
	struct module *owner = cls_session->transport->owner;

	struct Scsi_Host *shost = session->host;



	iscsi_pool_free(&session->cmdpool);



	iscsi_remove_session(cls_session);



	iscsi_pool_free(&session->cmdpool);

	kfree(session->password);

	kfree(session->password_in);

	kfree(session->username);