Commit a1e44708 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Moritz Fischer
Browse files

fpga: machxo2-spi: Fix missing error code in machxo2_write_complete() 



The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
  warn: missing error code 'ret'.

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a00 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarMoritz Fischer <mdf@kernel.org>
parent 34331739

drivers/fpga/machxo2-spi.c

+1 −0
Original line number Diff line number Diff line
@@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr, 
			break;

		if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {

			machxo2_cleanup(mgr);

			ret = -EINVAL;

			goto fail;

		}

	} while (1);