Commit a19eda0f authored by Soren Brinkmann's avatar Soren Brinkmann Committed by Greg Kroah-Hartman
Browse files

tty: xuartps: Acquire port lock for shutdown 



Shutting down the UART port can happen while console operations are in
progress. Holding the port lock serializes these operations and avoids
the UART HW to be disabled in the middle of console prints.

Signed-off-by: default avatarSoren Brinkmann <soren.brinkmann@xilinx.com>
Reviewed-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c0b92ed

drivers/tty/serial/xilinx_uartps.c

+6 −0
Original line number Diff line number Diff line
@@ -826,6 +826,9 @@ static int cdns_uart_startup(struct uart_port *port) 
static void cdns_uart_shutdown(struct uart_port *port)

{

	int status;

	unsigned long flags;



	spin_lock_irqsave(&port->lock, flags);



	/* Disable interrupts */

	status = readl(port->membase + CDNS_UART_IMR_OFFSET);
@@ -835,6 +838,9 @@ static void cdns_uart_shutdown(struct uart_port *port) 
	/* Disable the TX and RX */

	writel(CDNS_UART_CR_TX_DIS | CDNS_UART_CR_RX_DIS,

			port->membase + CDNS_UART_CR_OFFSET);



	spin_unlock_irqrestore(&port->lock, flags);



	free_irq(port->irq, port);

}