Commit a19c61b0 authored by Mario Limonciello's avatar Mario Limonciello Committed by Herbert Xu
Browse files

crypto: ccp - Return doorbell status code as an argument 



If the doorbell failed to ring we return -EIO, but the caller can't
determine why it failed.  Pass the reason for the failure in an
argument for caller to investigate.

Suggested-by: default avatarMark Hasemeyer <markhas@chromium.org>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarMark Hasemeyer <markhas@chromium.org>
Tested-by: default avatarMark Hasemeyer <markhas@chromium.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e0358ded

drivers/crypto/ccp/platform-access.c

+3 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ int psp_send_platform_access_msg(enum psp_platform_access_msg msg, 
}

EXPORT_SYMBOL_GPL(psp_send_platform_access_msg);



int psp_ring_platform_doorbell(int msg)

int psp_ring_platform_doorbell(int msg, u32 *result)

{

	struct psp_device *psp = psp_get_master_device();

	struct psp_platform_access_device *pa_dev;
@@ -164,6 +164,8 @@ int psp_ring_platform_doorbell(int msg) 


	val = FIELD_GET(PSP_CMDRESP_STS, ioread32(cmd));

	if (val) {

		if (result)

			*result = val;

		ret = -EIO;

		goto unlock;

	}

include/linux/psp-platform-access.h

+2 −2
Original line number Diff line number Diff line
@@ -45,9 +45,9 @@ int psp_send_platform_access_msg(enum psp_platform_access_msg, struct psp_reques 
 *  -%EBUSY:     mailbox in recovery or in use

 *  -%ENODEV:    driver not bound with PSP device

 *  -%ETIMEDOUT: request timed out

 *  -%EIO:       unknown error (see kernel log)

 *  -%EIO:       error will be stored in result argument

 */

int psp_ring_platform_doorbell(int msg);

int psp_ring_platform_doorbell(int msg, u32 *result);



/**

 * psp_check_platform_access_status() - Checks whether platform features is ready