Commit a163148c authored by Kim Nordlund's avatar Kim Nordlund Committed by David S. Miller
Browse files

[PKT_SCHED] act_gact: division by zero 



Not returning -EINVAL, because someone might want to use the value
zero in some future gact_prob algorithm?

Signed-off-by: default avatarKim Nordlund <kim.nordlund@nokia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0b251df1

net/sched/act_gact.c

+2 −2
Original line number Diff line number Diff line
@@ -48,14 +48,14 @@ static struct tcf_hashinfo gact_hash_info = { 
#ifdef CONFIG_GACT_PROB

static int gact_net_rand(struct tcf_gact *gact)

{

	if (net_random() % gact->tcfg_pval)

	if (!gact->tcfg_pval || net_random() % gact->tcfg_pval)

		return gact->tcf_action;

	return gact->tcfg_paction;

}



static int gact_determ(struct tcf_gact *gact)

{

	if (gact->tcf_bstats.packets % gact->tcfg_pval)

	if (!gact->tcfg_pval || gact->tcf_bstats.packets % gact->tcfg_pval)

		return gact->tcf_action;

	return gact->tcfg_paction;

}