Commit a137f3f2 authored by Gaosheng Cui's avatar Gaosheng Cui Committed by David S. Miller
Browse files

net: stmmac: fix possible memory leak in stmmac_dvr_probe() 



The bitmap_free() should be called to free priv->af_xdp_zc_qps
when create_singlethread_workqueue() fails, otherwise there will
be a memory leak, so we add the err path error_wq_init to fix it.

Fixes: bba2556e ("net: stmmac: Enable RX via AF_XDP zero-copy")
Signed-off-by: default avatarGaosheng Cui <cuigaosheng1@huawei.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f150b63f

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+2 −1
Original line number Diff line number Diff line
@@ -7097,7 +7097,7 @@ int stmmac_dvr_probe(struct device *device, 
	priv->wq = create_singlethread_workqueue("stmmac_wq");

	if (!priv->wq) {

		dev_err(priv->device, "failed to create workqueue\n");

		return -ENOMEM;

		goto error_wq_init;

	}



	INIT_WORK(&priv->service_task, stmmac_service_task);
@@ -7325,6 +7325,7 @@ int stmmac_dvr_probe(struct device *device, 
	stmmac_napi_del(ndev);

error_hw_init:

	destroy_workqueue(priv->wq);

error_wq_init:

	bitmap_free(priv->af_xdp_zc_qps);



	return ret;