Commit a109073b authored by Rikard Falkeborn's avatar Rikard Falkeborn Committed by Mauro Carvalho Chehab
Browse files

media: rockchip: rkisp1: Constify static structs 



These 'ops' structs are never modified, so make them const to allow the
compiler to put them in read-only memory.

Signed-off-by: default avatarRikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 1ed36ecd

drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c

+3 −3
Original line number Diff line number Diff line
@@ -565,7 +565,7 @@ static void rkisp1_sp_set_data_path(struct rkisp1_capture *cap) 
	rkisp1_write(cap->rkisp1, dpcl, RKISP1_CIF_VI_DPCL);

}



static struct rkisp1_capture_ops rkisp1_capture_ops_mp = {

static const struct rkisp1_capture_ops rkisp1_capture_ops_mp = {

	.config = rkisp1_mp_config,

	.enable = rkisp1_mp_enable,

	.disable = rkisp1_mp_disable,
@@ -574,7 +574,7 @@ static struct rkisp1_capture_ops rkisp1_capture_ops_mp = { 
	.is_stopped = rkisp1_mp_is_stopped,

};



static struct rkisp1_capture_ops rkisp1_capture_ops_sp = {

static const struct rkisp1_capture_ops rkisp1_capture_ops_sp = {

	.config = rkisp1_sp_config,

	.enable = rkisp1_sp_enable,

	.disable = rkisp1_sp_disable,
@@ -1038,7 +1038,7 @@ rkisp1_vb2_start_streaming(struct vb2_queue *queue, unsigned int count) 
	return ret;

}



static struct vb2_ops rkisp1_vb2_ops = {

static const struct vb2_ops rkisp1_vb2_ops = {

	.queue_setup = rkisp1_vb2_queue_setup,

	.buf_queue = rkisp1_vb2_buf_queue,

	.buf_prepare = rkisp1_vb2_buf_prepare,

drivers/media/platform/rockchip/rkisp1/rkisp1-common.h

+1 −1
Original line number Diff line number Diff line
@@ -214,7 +214,7 @@ struct rkisp1_capture { 
	struct rkisp1_vdev_node vnode;

	struct rkisp1_device *rkisp1;

	enum rkisp1_stream_id id;

	struct rkisp1_capture_ops *ops;

	const struct rkisp1_capture_ops *ops;

	const struct rkisp1_capture_config *config;

	bool is_streaming;

	bool is_stopping;

drivers/media/platform/rockchip/rkisp1/rkisp1-params.c

+2 −2
Original line number Diff line number Diff line
@@ -1469,7 +1469,7 @@ static void rkisp1_params_vb2_stop_streaming(struct vb2_queue *vq) 
		vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);

}



static struct vb2_ops rkisp1_params_vb2_ops = {

static const struct vb2_ops rkisp1_params_vb2_ops = {

	.queue_setup = rkisp1_params_vb2_queue_setup,

	.wait_prepare = vb2_ops_wait_prepare,

	.wait_finish = vb2_ops_wait_finish,
@@ -1479,7 +1479,7 @@ static struct vb2_ops rkisp1_params_vb2_ops = { 


};



static struct v4l2_file_operations rkisp1_params_fops = {

static const struct v4l2_file_operations rkisp1_params_fops = {

	.mmap = vb2_fop_mmap,

	.unlocked_ioctl = video_ioctl2,

	.poll = vb2_fop_poll,