Commit a0fc8688 authored Sep 01, 2022 by Tomer Tayar Committed by Oded Gabbay Sep 19, 2022

habanalabs/gaudi2: read F/W security indication after hard reset



F/W security status might change after every reset.

Add the reading of the preboot status to the hard reset sequence, which
among others reads this security indication.

As this preboot status reading includes the waiting for the preboot to
be ready, it can be removed from the CPU init which is done in a later
stage.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

parent aee3fd74

drivers/misc/habanalabs/common/device.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1563,6 +1563,13 @@ int hl_device_reset(struct hl_device *hdev, u32 flags)
		*/
		hdev->disabled = false;

		/* F/W security enabled indication might be updated after hard-reset */
		if (hard_reset) {
		rc = hl_fw_read_preboot_status(hdev);
		if (rc)
		goto out_err;
		}

		rc = hdev->asic_funcs->hw_init(hdev);
		if (rc) {
		dev_err(hdev->dev, "failed to initialize the H/W after reset\n");

drivers/misc/habanalabs/common/firmware_if.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -2509,13 +2509,6 @@ static int hl_fw_dynamic_init_cpu(struct hl_device *hdev,
		*/
		dyn_regs = &fw_loader->dynamic_loader.comm_desc.cpu_dyn_regs;

		/* if no preboot loaded indication- wait for preboot */
		if (!(hdev->fw_loader.fw_comp_loaded & FW_TYPE_PREBOOT_CPU)) {
		rc = hl_fw_wait_preboot_ready(hdev);
		if (rc)
		return -EIO;
		}

		rc = hl_fw_dynamic_send_protocol_cmd(hdev, fw_loader, COMMS_RST_STATE,
		0, true,
		fw_loader->cpu_timeout);