Commit a0f0dbaa authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Christoph Hellwig
Browse files

nvmet: use unsigned type for u64 



In function nvmet_subsys_atte_version_show() which uses the NVME_XXX()
macros related to version (of type u64) get rid of the int type cast
when printing subsys version and use appropriate format specifier for
u64.

Signed-off-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 6fa350f7

drivers/nvme/target/configfs.c

+8 −8
Original line number Diff line number Diff line
@@ -862,14 +862,14 @@ static ssize_t nvmet_subsys_attr_version_show(struct config_item *item, 
	struct nvmet_subsys *subsys = to_subsys(item);



	if (NVME_TERTIARY(subsys->ver))

		return snprintf(page, PAGE_SIZE, "%d.%d.%d\n",

				(int)NVME_MAJOR(subsys->ver),

				(int)NVME_MINOR(subsys->ver),

				(int)NVME_TERTIARY(subsys->ver));



	return snprintf(page, PAGE_SIZE, "%d.%d\n",

			(int)NVME_MAJOR(subsys->ver),

			(int)NVME_MINOR(subsys->ver));

		return snprintf(page, PAGE_SIZE, "%llu.%llu.%llu\n",

				NVME_MAJOR(subsys->ver),

				NVME_MINOR(subsys->ver),

				NVME_TERTIARY(subsys->ver));



	return snprintf(page, PAGE_SIZE, "%llu.%llu\n",

			NVME_MAJOR(subsys->ver),

			NVME_MINOR(subsys->ver));

}



static ssize_t nvmet_subsys_attr_version_store(struct config_item *item,