Commit a0e46db4 authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/cm: Increment the refcount inside cm_find_listen() 

All callers need the 'get', so do it in a central place before returning
the pointer.

Link: https://lore.kernel.org/r/20200506074701.9775-11-leon@kernel.org


Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 51e8463c

drivers/infiniband/core/cm.c

+3 −4
Original line number Diff line number Diff line
@@ -686,9 +686,10 @@ static struct cm_id_private * cm_find_listen(struct ib_device *device, 
		cm_id_priv = rb_entry(node, struct cm_id_private, service_node);

		if ((cm_id_priv->id.service_mask & service_id) ==

		     cm_id_priv->id.service_id &&

		    (cm_id_priv->id.device == device))

		    (cm_id_priv->id.device == device)) {

			refcount_inc(&cm_id_priv->refcount);

			return cm_id_priv;



		}

		if (device < cm_id_priv->id.device)

			node = node->rb_left;

		else if (device > cm_id_priv->id.device)
@@ -2005,7 +2006,6 @@ static struct cm_id_private * cm_match_req(struct cm_work *work, 
			     NULL, 0);

		return NULL;

	}

	refcount_inc(&listen_cm_id_priv->refcount);

	spin_unlock_irq(&cm.lock);

	return listen_cm_id_priv;

}
@@ -3564,7 +3564,6 @@ static int cm_sidr_req_handler(struct cm_work *work) 
					    .status = IB_SIDR_UNSUPPORTED });

		goto out; /* No match. */

	}

	refcount_inc(&listen_cm_id_priv->refcount);

	spin_unlock_irq(&cm.lock);



	cm_id_priv->id.cm_handler = listen_cm_id_priv->id.cm_handler;