Commit a0cc8e15 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amdgpu: Update min() to min_t() in 'amdgpu_info_ioctl' 



Fixes the following:

WARNING: min() should probably be min_t(size_t, size, sizeof(ip))
+               ret = copy_to_user(out, &ip, min((size_t)size, sizeof(ip)));

And other style fixes:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
WARNING: Missing a blank line after declarations

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ce83aa7b

drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

+8 −6
Original line number Diff line number Diff line
@@ -557,6 +557,7 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) 
			crtc = (struct drm_crtc *)minfo->crtcs[i];

			if (crtc && crtc->base.id == info->mode_crtc.id) {

				struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);



				ui32 = amdgpu_crtc->crtc_id;

				found = 1;

				break;
@@ -575,7 +576,7 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) 
		if (ret)

			return ret;



		ret = copy_to_user(out, &ip, min((size_t)size, sizeof(ip)));

		ret = copy_to_user(out, &ip, min_t(size_t, size, sizeof(ip)));

		return ret ? -EFAULT : 0;

	}

	case AMDGPU_INFO_HW_IP_COUNT: {
@@ -721,17 +722,18 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) 
				    ? -EFAULT : 0;

	}

	case AMDGPU_INFO_READ_MMR_REG: {

		unsigned n, alloc_size;

		unsigned int n, alloc_size;

		uint32_t *regs;

		unsigned se_num = (info->read_mmr_reg.instance >>

		unsigned int se_num = (info->read_mmr_reg.instance >>

				   AMDGPU_INFO_MMR_SE_INDEX_SHIFT) &

				  AMDGPU_INFO_MMR_SE_INDEX_MASK;

		unsigned sh_num = (info->read_mmr_reg.instance >>

		unsigned int sh_num = (info->read_mmr_reg.instance >>

				   AMDGPU_INFO_MMR_SH_INDEX_SHIFT) &

				  AMDGPU_INFO_MMR_SH_INDEX_MASK;



		/* set full masks if the userspace set all bits

		 * in the bitfields */

		 * in the bitfields

		 */

		if (se_num == AMDGPU_INFO_MMR_SE_INDEX_MASK)

			se_num = 0xffffffff;

		else if (se_num >= AMDGPU_GFX_MAX_SE)
@@ -896,7 +898,7 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) 
		return ret;

	}

	case AMDGPU_INFO_VCE_CLOCK_TABLE: {

		unsigned i;

		unsigned int i;

		struct drm_amdgpu_info_vce_clock_table vce_clk_table = {};

		struct amd_vce_state *vce_state;