Commit a0cb9096 authored by Gal Pressman's avatar Gal Pressman Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix skb memory leak when TC classifier action offloads are disabled 



When TC classifier action offloads are disabled (CONFIG_MLX5_CLS_ACT in
Kconfig), the mlx5e_rep_tc_receive() function which is responsible for
passing the skb to the stack (or freeing it) is defined as a nop, and
results in leaking the skb memory. Replace the nop with a call to
napi_gro_receive() to resolve the leak.

Fixes: 28e7606f ("net/mlx5e: Refactor rx handler of represetor device")
Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarAriel Levkovich <lariel@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 918fc385

drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.h

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ mlx5e_rep_setup_tc(struct net_device *dev, enum tc_setup_type type, 


static inline void

mlx5e_rep_tc_receive(struct mlx5_cqe64 *cqe, struct mlx5e_rq *rq,

		     struct sk_buff *skb) {}

		     struct sk_buff *skb) { napi_gro_receive(rq->cq.napi, skb); }



#endif /* CONFIG_MLX5_CLS_ACT */