Commit a0be10c2 authored by Michael Rissi's avatar Michael Rissi Committed by Jiri Kosina
Browse files

HID: roccat: check cdev_add return value 



Return value of cdev_add in hid_roccat.c init was not checked.

Signed-off-by: default avatarMichael Rissi <michael.rissi@dectris.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a4a23f6d

drivers/hid/hid-roccat.c

+13 −3
Original line number Diff line number Diff line
@@ -426,13 +426,23 @@ static int __init roccat_init(void) 


	if (retval < 0) {

		pr_warn("can't get major number\n");

		return retval;

		goto error;

	}



	cdev_init(&roccat_cdev, &roccat_ops);

	cdev_add(&roccat_cdev, dev_id, ROCCAT_MAX_DEVICES);

	retval = cdev_add(&roccat_cdev, dev_id, ROCCAT_MAX_DEVICES);



	if (retval < 0) {

		pr_warn("cannot add cdev\n");

		goto cleanup_alloc_chrdev_region;

	}

	return 0;





 cleanup_alloc_chrdev_region:

	unregister_chrdev_region(dev_id, ROCCAT_MAX_DEVICES);

 error:

	return retval;

}



static void __exit roccat_exit(void)