Commit a09d2d00 authored by Hyunwoo Kim's avatar Hyunwoo Kim Committed by Helge Deller
Browse files

video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write 



In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
type int.  Then, copy_from_user() may cause a heap overflow because it is used
as the third argument of copy_from_user().

Signed-off-by: default avatarHyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 267173cb

drivers/video/fbdev/pxa3xx-gcu.c

+1 −1
Original line number Diff line number Diff line
@@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff, 
	struct pxa3xx_gcu_batch	*buffer;

	struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file);



	int words = count / 4;

	size_t words = count / 4;



	/* Does not need to be atomic. There's a lock in user space,

	 * but anyhow, this is just for statistics. */