Commit a092b723 authored by Himadri Pandya's avatar Himadri Pandya Committed by David S. Miller
Browse files

net: usb: Fix uninit-was-stored issue in asix_read_phy_addr() 



The buffer size is 2 Bytes and we expect to receive the same amount of
data. But sometimes we receive less data and run into uninit-was-stored
issue upon read. Hence modify the error check on the return value to match
with the buffer size as a prevention.

Reported-and-tested by: syzbot+a7e220df5a81d1ab400e@syzkaller.appspotmail.com
Signed-off-by: default avatarHimadri Pandya <himadrispandya@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5875568a

drivers/net/usb/asix_common.c

+1 −1
Original line number Diff line number Diff line
@@ -296,7 +296,7 @@ int asix_read_phy_addr(struct usbnet *dev, int internal) 


	netdev_dbg(dev->net, "asix_get_phy_addr()\n");



	if (ret < 0) {

	if (ret < 2) {

		netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);

		goto out;

	}