Commit a0796e2a authored by Schspa Shi's avatar Schspa Shi Committed by sanglipeng1
Browse files

scripts/decode_stacktrace.sh: support old bash version 

stable inclusion
from stable-v5.10.210
commit a3d71b6ae935b0343f191be610cd1e5518bfbf99
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAE52H

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a3d71b6ae935b0343f191be610cd1e5518bfbf99

--------------------------------

[ Upstream commit 3af8acf6 ]

Old bash version don't support associative array variables.  Avoid to use
associative array variables to avoid error.

Without this, old bash version will report error as fellowing
[   15.954042] Kernel panic - not syncing: sysrq triggered crash
[   15.955252] CPU: 1 PID: 167 Comm: sh Not tainted 5.18.0-rc1-00208-gb7d075db2fd5 #4
[   15.956472] Hardware name: Hobot J5 Virtual development board (DT)
[   15.957856] Call trace:
./scripts/decode_stacktrace.sh: line 128: ,dump_backtrace: syntax error: operand expected (error token is ",dump_backtrace")

Link: https://lkml.kernel.org/r/20220409180331.24047-1-schspa@gmail.com


Signed-off-by: default avatarSchspa Shi <schspa@gmail.com>
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Stable-dep-of: efbd63983533 ("scripts/decode_stacktrace.sh: optionally use LLVM utilities")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng1 <sanglipeng1@jd.com>
parent de8ca627

scripts/decode_stacktrace.sh

+19 −8
Original line number Diff line number Diff line
@@ -33,8 +33,13 @@ else 
	release=""

fi



declare -A cache

declare aarray_support=true

declare -A cache 2>/dev/null

if [[ $? != 0 ]]; then

	aarray_support=false

else

	declare -A modcache

fi



find_module() {

	if [[ "$modpath" != "" ]] ; then
@@ -74,7 +79,7 @@ parse_symbol() { 


	if [[ $module == "" ]] ; then

		local objfile=$vmlinux

	elif [[ "${modcache[$module]+isset}" == "isset" ]]; then

	elif [[ $aarray_support == true && "${modcache[$module]+isset}" == "isset" ]]; then

		local objfile=${modcache[$module]}

	else

		local objfile=$(find_module)
@@ -82,8 +87,10 @@ parse_symbol() { 
			echo "WARNING! Modules path isn't set, but is needed to parse this symbol" >&2

			return

		fi

		if [[ $aarray_support == true ]]; then

			modcache[$module]=$objfile

		fi

	fi



	# Remove the englobing parenthesis

	symbol=${symbol#\(}
@@ -102,7 +109,7 @@ parse_symbol() { 
	# Use 'nm vmlinux' to figure out the base address of said symbol.

	# It's actually faster to call it every time than to load it

	# all into bash.

	if [[ "${cache[$module,$name]+isset}" == "isset" ]]; then

	if [[ $aarray_support == true && "${cache[$module,$name]+isset}" == "isset" ]]; then

		local base_addr=${cache[$module,$name]}

	else

		local base_addr=$(nm "$objfile" 2>/dev/null | awk '$3 == "'$name'" && ($2 == "t" || $2 == "T") {print $1; exit}')
@@ -110,8 +117,10 @@ parse_symbol() { 
			# address not found

			return

		fi

		if [[ $aarray_support == true ]]; then

			cache[$module,$name]="$base_addr"

		fi

	fi

	# Let's start doing the math to get the exact address into the

	# symbol. First, strip out the symbol total length.

	local expr=${symbol%/*}
@@ -126,12 +135,14 @@ parse_symbol() { 


	# Pass it to addr2line to get filename and line number

	# Could get more than one result

	if [[ "${cache[$module,$address]+isset}" == "isset" ]]; then

	if [[ $aarray_support == true && "${cache[$module,$address]+isset}" == "isset" ]]; then

		local code=${cache[$module,$address]}

	else

		local code=$(${CROSS_COMPILE}addr2line -i -e "$objfile" "$address" 2>/dev/null)

		if [[ $aarray_support == true ]]; then

			cache[$module,$address]=$code

		fi

	fi



	# addr2line doesn't return a proper error code if it fails, so

	# we detect it using the value it prints so that we could preserve