Commit a053d9dc authored by Jeff Layton's avatar Jeff Layton Committed by Greg Kroah-Hartman
Browse files

usb: update the ctime as well when updating mtime after an ioctl 



In general, POSIX requires that when the mtime is updated that the ctime
be updated as well. Add the missing timestamp updates to the usb ioctls.

Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Message-ID: <20230612104524.17058-3-jlayton@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 83cb2604

drivers/usb/core/devio.c

+8 −8
Original line number Diff line number Diff line
@@ -2642,21 +2642,21 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, 
		snoop(&dev->dev, "%s: CONTROL\n", __func__);

		ret = proc_control(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_BULK:

		snoop(&dev->dev, "%s: BULK\n", __func__);

		ret = proc_bulk(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_RESETEP:

		snoop(&dev->dev, "%s: RESETEP\n", __func__);

		ret = proc_resetep(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_RESET:
@@ -2668,7 +2668,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, 
		snoop(&dev->dev, "%s: CLEAR_HALT\n", __func__);

		ret = proc_clearhalt(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_GETDRIVER:
@@ -2695,7 +2695,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, 
		snoop(&dev->dev, "%s: SUBMITURB\n", __func__);

		ret = proc_submiturb(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



#ifdef CONFIG_COMPAT
@@ -2703,14 +2703,14 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, 
		snoop(&dev->dev, "%s: CONTROL32\n", __func__);

		ret = proc_control_compat(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_BULK32:

		snoop(&dev->dev, "%s: BULK32\n", __func__);

		ret = proc_bulk_compat(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_DISCSIGNAL32:
@@ -2722,7 +2722,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, 
		snoop(&dev->dev, "%s: SUBMITURB32\n", __func__);

		ret = proc_submiturb_compat(ps, p);

		if (ret >= 0)

			inode->i_mtime = current_time(inode);

			inode->i_mtime = inode->i_ctime = current_time(inode);

		break;



	case USBDEVFS_IOCTL32: