Commit a03d263c authored by SurajSonawane2415's avatar SurajSonawane2415 Committed by Wen Zhiwei
Browse files

hid: intel-ish-hid: Fix uninitialized variable 'rv' in ish_fw_xfer_direct_dma 

stable inclusion
from stable-v6.6.57
commit fb1643d00a505d54d90aa2a3470b35c8a0ff2ee5
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB2M97

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=fb1643d00a505d54d90aa2a3470b35c8a0ff2ee5



--------------------------------

commit d41bff05a61fb539f21e9bf0d39fac77f457434e upstream.

Fix the uninitialized symbol 'rv' in the function ish_fw_xfer_direct_dma
to resolve the following warning from the smatch tool:
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:714 ish_fw_xfer_direct_dma()
error: uninitialized symbol 'rv'.
Initialize 'rv' to 0 to prevent undefined behavior from uninitialized
access.

Cc: stable@vger.kernel.org
Fixes: 91b22810 ("HID: intel-ish-hid: ISH firmware loader client driver")
Signed-off-by: default avatarSurajSonawane2415 <surajsonawane0215@gmail.com>
Link: https://patch.msgid.link/20241004075944.44932-1-surajsonawane0215@gmail.com


Signed-off-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent 494439de

drivers/hid/intel-ish-hid/ishtp-fw-loader.c

+1 −1
Original line number Diff line number Diff line
@@ -635,7 +635,7 @@ static int ish_fw_xfer_direct_dma(struct ishtp_cl_data *client_data, 
				  const struct firmware *fw,

				  const struct shim_fw_info fw_info)

{

	int rv;

	int rv = 0;

	void *dma_buf;

	dma_addr_t dma_buf_phy;

	u32 fragment_offset, fragment_size, payload_max_size;