Commit a0072320 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_conncount: fix argument order to find_next_bit 



Size and 'next bit' were swapped, this bug could cause worker to
reschedule itself even if system was idle.

Fixes: 5c789e13 ("netfilter: nf_conncount: Add list lock and gc worker, and RCU for init tree search")
Reviewed-by: default avatarShawn Bohrer <sbohrer@cloudflare.com>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent c80f10bc

net/netfilter/nf_conncount.c

+1 −1
Original line number Diff line number Diff line
@@ -488,7 +488,7 @@ static void tree_gc_worker(struct work_struct *work) 
	clear_bit(tree, data->pending_trees);



	next_tree = (tree + 1) % CONNCOUNT_SLOTS;

	next_tree = find_next_bit(data->pending_trees, next_tree, CONNCOUNT_SLOTS);

	next_tree = find_next_bit(data->pending_trees, CONNCOUNT_SLOTS, next_tree);



	if (next_tree < CONNCOUNT_SLOTS) {

		data->gc_tree = next_tree;