Commit a006805c authored by Ma Ke's avatar Ma Ke Committed by Wen Zhiwei
Browse files

drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check 

stable inclusion
from stable-v6.6.64
commit 82a5312f874fb18f045d9658e9bd290e3b0621c0
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IBL4B6

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=82a5312f874fb18f045d9658e9bd290e3b0621c0



--------------------------------

commit c1ab40a1fdfee732c7e6ff2fb8253760293e47e8 upstream.

The return value of drm_atomic_get_crtc_state() needs to be
checked. To avoid use of error pointer 'crtc_state' in case
of the failure.

Cc: stable@vger.kernel.org
Fixes: dd86dc2f ("drm/sti: implement atomic_check for the planes")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Link: https://patchwork.freedesktop.org/patch/msgid/20240913090926.2023716-1-make24@iscas.ac.cn


Signed-off-by: default avatarAlain Volmat <alain.volmat@foss.st.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent ea799aa4

drivers/gpu/drm/sti/sti_hqvdp.c

+3 −0
Original line number Diff line number Diff line
@@ -1037,6 +1037,9 @@ static int sti_hqvdp_atomic_check(struct drm_plane *drm_plane, 
		return 0;



	crtc_state = drm_atomic_get_crtc_state(state, crtc);

	if (IS_ERR(crtc_state))

		return PTR_ERR(crtc_state);



	mode = &crtc_state->mode;

	dst_x = new_plane_state->crtc_x;

	dst_y = new_plane_state->crtc_y;