Commit a0061be4 authored by Ping-Ke Shih's avatar Ping-Ke Shih Committed by Kalle Valo
Browse files

rtw88: change rtw_info() to proper message level 

Larry reported funny log entries [1] when he used rtl8821ce. These
messages are not harmless, but not useful for users, so change them to
rtw_dbg() level. By the way, I review all rtw_info() and change others
to rtw_warn().

[1] https://lore.kernel.org/linux-wireless/c356d5ae-a7b3-3065-1121-64c446e70333@lwfinger.net/



Reported-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220218035527.9835-1-pkshih@realtek.com
parent a9e06f2e

drivers/net/wireless/realtek/rtw88/debug.c

+1 −1
Original line number Diff line number Diff line
@@ -390,7 +390,7 @@ static ssize_t rtw_debugfs_set_h2c(struct file *filp, 
		     &param[0], &param[1], &param[2], &param[3],

		     &param[4], &param[5], &param[6], &param[7]);

	if (num != 8) {

		rtw_info(rtwdev, "invalid H2C command format for debug\n");

		rtw_warn(rtwdev, "invalid H2C command format for debug\n");

		return -EINVAL;

	}

drivers/net/wireless/realtek/rtw88/debug.h

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ enum rtw_debug_mask { 
	RTW_DBG_PATH_DIV	= 0x00004000,

	RTW_DBG_ADAPTIVITY	= 0x00008000,

	RTW_DBG_HW_SCAN		= 0x00010000,

	RTW_DBG_STATE		= 0x00020000,



	RTW_DBG_ALL		= 0xffffffff

};

drivers/net/wireless/realtek/rtw88/fw.c

+1 −1
Original line number Diff line number Diff line
@@ -2146,7 +2146,7 @@ void rtw_hw_scan_status_report(struct rtw_dev *rtwdev, struct sk_buff *skb) 
	rtw_hw_scan_complete(rtwdev, vif, aborted);



	if (aborted)

		rtw_info(rtwdev, "HW scan aborted with code: %d\n", rc);

		rtw_dbg(rtwdev, RTW_DBG_HW_SCAN, "HW scan aborted with code: %d\n", rc);

}



void rtw_store_op_chan(struct rtw_dev *rtwdev)

drivers/net/wireless/realtek/rtw88/mac80211.c

+4 −4
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ static int rtw_ops_add_interface(struct ieee80211_hw *hw, 


	mutex_unlock(&rtwdev->mutex);



	rtw_info(rtwdev, "start vif %pM on port %d\n", vif->addr, rtwvif->port);

	rtw_dbg(rtwdev, RTW_DBG_STATE, "start vif %pM on port %d\n", vif->addr, rtwvif->port);

	return 0;

}
@@ -219,7 +219,7 @@ static void rtw_ops_remove_interface(struct ieee80211_hw *hw, 
	struct rtw_vif *rtwvif = (struct rtw_vif *)vif->drv_priv;

	u32 config = 0;



	rtw_info(rtwdev, "stop vif %pM on port %d\n", vif->addr, rtwvif->port);

	rtw_dbg(rtwdev, RTW_DBG_STATE, "stop vif %pM on port %d\n", vif->addr, rtwvif->port);



	mutex_lock(&rtwdev->mutex);
@@ -245,7 +245,7 @@ static int rtw_ops_change_interface(struct ieee80211_hw *hw, 
{

	struct rtw_dev *rtwdev = hw->priv;



	rtw_info(rtwdev, "change vif %pM (%d)->(%d), p2p (%d)->(%d)\n",

	rtw_dbg(rtwdev, RTW_DBG_STATE, "change vif %pM (%d)->(%d), p2p (%d)->(%d)\n",

		vif->addr, vif->type, type, vif->p2p, p2p);



	rtw_ops_remove_interface(hw, vif);

drivers/net/wireless/realtek/rtw88/main.c

+4 −4
Original line number Diff line number Diff line
@@ -317,7 +317,7 @@ int rtw_sta_add(struct rtw_dev *rtwdev, struct ieee80211_sta *sta, 


	rtwdev->sta_cnt++;

	rtwdev->beacon_loss = false;

	rtw_info(rtwdev, "sta %pM joined with macid %d\n",

	rtw_dbg(rtwdev, RTW_DBG_STATE, "sta %pM joined with macid %d\n",

		sta->addr, si->mac_id);



	return 0;
@@ -339,7 +339,7 @@ void rtw_sta_remove(struct rtw_dev *rtwdev, struct ieee80211_sta *sta, 
	kfree(si->mask);



	rtwdev->sta_cnt--;

	rtw_info(rtwdev, "sta %pM with macid %d left\n",

	rtw_dbg(rtwdev, RTW_DBG_STATE, "sta %pM with macid %d left\n",

		sta->addr, si->mac_id);

}