Commit 9fc33eaa authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Steven Price
Browse files

drm/panfrost: Fix shrinker list corruption by madvise IOCTL 



Calling madvise IOCTL twice on BO causes memory shrinker list corruption
and crashes kernel because BO is already on the list and it's added to
the list again, while BO should be removed from the list before it's
re-added. Fix it.

Cc: stable@vger.kernel.org
Fixes: 013b6510 ("drm/panfrost: Add madvise and shrinker support")
Acked-by: default avatarAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Signed-off-by: default avatarDmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220630200601.1884120-3-dmitry.osipenko@collabora.com
parent fb6e0637

drivers/gpu/drm/panfrost/panfrost_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ static int panfrost_ioctl_madvise(struct drm_device *dev, void *data, 


	if (args->retained) {

		if (args->madv == PANFROST_MADV_DONTNEED)

			list_add_tail(&bo->base.madv_list,

			list_move_tail(&bo->base.madv_list,

				       &pfdev->shrinker_list);

		else if (args->madv == PANFROST_MADV_WILLNEED)

			list_del_init(&bo->base.madv_list);