Commit 9f9d17c2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij
Browse files

pinctrl: mediatek: add a check for error in mtk_pinconf_bias_get_rsel() 



All the other mtk_hw_get_value() calls have a check for "if (err)" so
we can add one here as well.  This silences a Smatch warning:

    drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:819 mtk_pinconf_bias_get_rsel()
    error: uninitialized symbol 'pd'.

Fixes: fb34a9ae ("pinctrl: mediatek: support rsel feature")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211127140836.GB24002@kili


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 67bbbcb4

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c

+2 −0
Original line number Diff line number Diff line
@@ -811,6 +811,8 @@ static int mtk_pinconf_bias_get_rsel(struct mtk_pinctrl *hw, 
		goto out;



	err = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_PD, &pd);

	if (err)

		goto out;



	if (pu == 0 && pd == 0) {

		*pullup = 0;