Commit 9f8308f4 authored by Patrik Jakobsson's avatar Patrik Jakobsson
Browse files

drm/gma500: gma500 don't register non-hotpluggable connectors 



According to docs we should only register connectors that are
hotpluggable. No connectors in gma500 are hotpluggable.

Signed-off-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220322131742.11566-4-patrik.r.jakobsson@gmail.com
parent b1a7d0dd

drivers/gpu/drm/gma500/cdv_intel_crt.c

+0 −3
Original line number Diff line number Diff line
@@ -194,7 +194,6 @@ static void cdv_intel_crt_destroy(struct drm_connector *connector) 
	struct gma_encoder *gma_encoder = gma_attached_encoder(connector);



	psb_intel_i2c_destroy(gma_encoder->ddc_bus);

	drm_connector_unregister(connector);

	drm_connector_cleanup(connector);

	kfree(connector);

}
@@ -281,8 +280,6 @@ void cdv_intel_crt_init(struct drm_device *dev, 
	drm_connector_helper_add(connector,

					&cdv_intel_crt_connector_helper_funcs);



	drm_connector_register(connector);



	return;

failed_ddc:

	drm_encoder_cleanup(&gma_encoder->base);

drivers/gpu/drm/gma500/cdv_intel_dp.c

+0 −3
Original line number Diff line number Diff line
@@ -1866,7 +1866,6 @@ cdv_intel_dp_destroy(struct drm_connector *connector) 
		intel_dp->panel_fixed_mode = NULL;

	}

	i2c_del_adapter(&intel_dp->adapter);

	drm_connector_unregister(connector);

	drm_connector_cleanup(connector);

	kfree(connector);

}
@@ -1990,8 +1989,6 @@ cdv_intel_dp_init(struct drm_device *dev, struct psb_intel_mode_device *mode_dev 
	connector->interlace_allowed = false;

	connector->doublescan_allowed = false;



	drm_connector_register(connector);



	/* Set up the DDC bus. */

	switch (output_reg) {

		case DP_B:

drivers/gpu/drm/gma500/cdv_intel_hdmi.c

+0 −2
Original line number Diff line number Diff line
@@ -245,7 +245,6 @@ static void cdv_hdmi_destroy(struct drm_connector *connector) 
	struct gma_encoder *gma_encoder = gma_attached_encoder(connector);



	psb_intel_i2c_destroy(gma_encoder->i2c_bus);

	drm_connector_unregister(connector);

	drm_connector_cleanup(connector);

	kfree(connector);

}
@@ -352,7 +351,6 @@ void cdv_hdmi_init(struct drm_device *dev, 


	hdmi_priv->hdmi_i2c_adapter = &(gma_encoder->i2c_bus->adapter);

	hdmi_priv->dev = dev;

	drm_connector_register(connector);

	return;



failed_ddc:

drivers/gpu/drm/gma500/cdv_intel_lvds.c

+0 −2
Original line number Diff line number Diff line
@@ -329,7 +329,6 @@ static void cdv_intel_lvds_destroy(struct drm_connector *connector) 
	struct gma_encoder *gma_encoder = gma_attached_encoder(connector);



	psb_intel_i2c_destroy(gma_encoder->i2c_bus);

	drm_connector_unregister(connector);

	drm_connector_cleanup(connector);

	kfree(connector);

}
@@ -647,7 +646,6 @@ void cdv_intel_lvds_init(struct drm_device *dev, 


out:

	mutex_unlock(&dev->mode_config.mutex);

	drm_connector_register(connector);

	return;



failed_find:

drivers/gpu/drm/gma500/oaktrail_hdmi.c

+0 −1
Original line number Diff line number Diff line
@@ -654,7 +654,6 @@ void oaktrail_hdmi_init(struct drm_device *dev, 
	connector->display_info.subpixel_order = SubPixelHorizontalRGB;

	connector->interlace_allowed = false;

	connector->doublescan_allowed = false;

	drm_connector_register(connector);

	dev_info(dev->dev, "HDMI initialised.\n");



	return;