Commit 9f414eb4 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by David S. Miller
Browse files

rds: add missing barrier to release_refill 



The functions clear_bit and set_bit do not imply a memory barrier, thus it
may be possible that the waitqueue_active function (which does not take
any locks) is moved before clear_bit and it could miss a wakeup event.

Fix this bug by adding a memory barrier after clear_bit.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7ebfc85e

net/rds/ib_recv.c

+1 −0
Original line number Diff line number Diff line
@@ -363,6 +363,7 @@ static int acquire_refill(struct rds_connection *conn) 
static void release_refill(struct rds_connection *conn)

{

	clear_bit(RDS_RECV_REFILL, &conn->c_flags);

	smp_mb__after_atomic();



	/* We don't use wait_on_bit()/wake_up_bit() because our waking is in a

	 * hot path and finding waiters is very rare.  We don't want to walk