Unverified Commit 9f376291 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!13042 tty: n_gsm: Fix use-after-free in gsm_cleanup_mux 

Merge Pull Request from: @ci-robot 
 
PR sync from: Yi Yang <yiyang13@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/LX5HA6E5W32UG27SZ7OUY2S6CEPLL2UN/ 
 
https://gitee.com/src-openeuler/kernel/issues/IB0EQM 
 
Link:https://gitee.com/openeuler/kernel/pulls/13042

 

Reviewed-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parents a1ff0c9f d7a55426

drivers/tty/n_gsm.c

+4 −0
Original line number Diff line number Diff line
@@ -2228,6 +2228,7 @@ static void gsm_cleanup_mux(struct gsm_mux *gsm, bool disc) 
	int i;

	struct gsm_dlci *dlci;

	struct gsm_msg *txq, *ntxq;

	unsigned long flags;



	gsm->dead = true;

	mutex_lock(&gsm->mutex);
@@ -2255,9 +2256,12 @@ static void gsm_cleanup_mux(struct gsm_mux *gsm, bool disc) 
	mutex_unlock(&gsm->mutex);

	/* Now wipe the queues */

	tty_ldisc_flush(gsm->tty);



	spin_lock_irqsave(&gsm->tx_lock, flags);

	list_for_each_entry_safe(txq, ntxq, &gsm->tx_list, list)

		kfree(txq);

	INIT_LIST_HEAD(&gsm->tx_list);

	spin_unlock_irqrestore(&gsm->tx_lock, flags);

}



/**