Commit 9f05c09d authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: remove BUG_ON(!eie) in find_parent_nodes 



If we're looking for leafs that point to a data extent we want to record
the extent items that point at our bytenr.  At this point we have the
reference and we know for a fact that this leaf should have a reference
to our bytenr.  However if there's some sort of corruption we may not
find any references to our leaf, and thus could end up with eie == NULL.
Replace this BUG_ON() with an ASSERT() and then return -EUCLEAN for the
mortals.

Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent fcba0120

fs/btrfs/backref.c

+11 −3
Original line number Diff line number Diff line
@@ -1359,10 +1359,18 @@ static int find_parent_nodes(struct btrfs_trans_handle *trans, 
				goto out;

			if (!ret && extent_item_pos) {

				/*

				 * we've recorded that parent, so we must extend

				 * its inode list here

				 * We've recorded that parent, so we must extend

				 * its inode list here.

				 *

				 * However if there was corruption we may not

				 * have found an eie, return an error in this

				 * case.

				 */

				BUG_ON(!eie);

				ASSERT(eie);

				if (!eie) {

					ret = -EUCLEAN;

					goto out;

				}

				while (eie->next)

					eie = eie->next;

				eie->next = ref->inode_list;