Commit 9eb5e54f authored Jul 04, 2022 by Sudeep Holla

arch_topology: Check for non-negative value rather than -1 for IDs validity

Instead of just comparing the cpu topology IDs with -1 to check their
validity, improve that by checking for a valid non-negative value.

Link: https://lore.kernel.org/r/20220704101605.1318280-15-sudeep.holla@arm.com


Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Tested-by: Ionela Voinescu <ionela.voinescu@arm.com>
Tested-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

parent 3f828329

drivers/base/arch_topology.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -642,7 +642,7 @@ static int __init parse_dt_topology(void)
		* only mark cores described in the DT as possible.
		*/
		for_each_possible_cpu(cpu)
		if (cpu_topology[cpu].package_id == -1)
		if (cpu_topology[cpu].package_id < 0)
		ret = -EINVAL;

		out_map:
		@@ -714,7 +714,7 @@ void update_siblings_masks(unsigned int cpuid)
		if (cpuid_topo->cluster_id != cpu_topo->cluster_id)
		continue;

		if (cpuid_topo->cluster_id != -1) {
		if (cpuid_topo->cluster_id >= 0) {
		cpumask_set_cpu(cpu, &cpuid_topo->cluster_sibling);
		cpumask_set_cpu(cpuid, &cpu_topo->cluster_sibling);
		}