Commit 9ea172a9 authored by Takashi Iwai's avatar Takashi Iwai Committed by Thomas Zimmermann
Browse files

drm/ast: Fix missing conversions to managed API 



The commit 7cbb93d8 ("drm/ast: Use managed pci functions")
converted a few PCI accessors to the managed API and dropped the
manual pci_iounmap() calls, but it seems to have forgotten converting
pci_iomap() to the managed one.  It resulted in the leftover resources
after the driver unbind.  Let's fix them.

Fixes: 7cbb93d8 ("drm/ast: Use managed pci functions")
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20210421170458.21178-1-tiwai@suse.de
parent 304a3519

drivers/gpu/drm/ast/ast_main.c

+2 −2
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ struct ast_private *ast_device_create(const struct drm_driver *drv, 


	pci_set_drvdata(pdev, dev);



	ast->regs = pci_iomap(pdev, 1, 0);

	ast->regs = pcim_iomap(pdev, 1, 0);

	if (!ast->regs)

		return ERR_PTR(-EIO);
@@ -429,7 +429,7 @@ struct ast_private *ast_device_create(const struct drm_driver *drv, 


	/* "map" IO regs if the above hasn't done so already */

	if (!ast->ioregs) {

		ast->ioregs = pci_iomap(pdev, 2, 0);

		ast->ioregs = pcim_iomap(pdev, 2, 0);

		if (!ast->ioregs)

			return ERR_PTR(-EIO);

	}