Commit 9e97c46f authored by Nirmoy Das's avatar Nirmoy Das Committed by Matthew Auld
Browse files

drm/i915: gracefully error out on platform with small-bar 



Currently we just fatally crash during module load if we encounter
small-BAR configuration on DG2. We have most of the support already, but
we lack the final uAPI bits to tie it all together.

Signed-off-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
[mauld: reword the commit and error message slightly]
Link: https://patchwork.freedesktop.org/patch/msgid/20220511153746.14142-3-nirmoy.das@intel.com
parent 8f6de231

drivers/gpu/drm/i915/gt/intel_region_lmem.c

+6 −0
Original line number Diff line number Diff line
@@ -111,6 +111,12 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) 
		flat_ccs_base = intel_gt_read_register(gt, XEHPSDV_FLAT_CCS_BASE_ADDR);

		flat_ccs_base = (flat_ccs_base >> XEHPSDV_CCS_BASE_SHIFT) * SZ_64K;



		/* FIXME: Remove this when we have small-bar enabled */

		if (pci_resource_len(pdev, 2) < lmem_size) {

			drm_err(&i915->drm, "System requires small-BAR support, which is currently unsupported on this kernel\n");

			return ERR_PTR(-EINVAL);

		}



		if (GEM_WARN_ON(lmem_size < flat_ccs_base))

			return ERR_PTR(-EIO);