Commit 9e6f4c8b authored by Prashant Malani's avatar Prashant Malani Committed by Greg Kroah-Hartman
Browse files

usb: typec: tcpm: Remove altmode active state updates 



Since the "active" state for partner altmodes is now being taken care of
by the altmode driver itself (specifically, DisplayPort altmode), we
no longer need to do so from the port driver. So remove the calls to
typec_altmode_update_active() from TCPM.

Suggested-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarBenson Leung <bleung@chromium.org>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarPrashant Malani <pmalani@chromium.org>
Link: https://lore.kernel.org/r/20230120205827.740900-2-pmalani@chromium.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 25d6d1bf

drivers/usb/typec/tcpm/tcpm.c

+1 −4
Original line number Diff line number Diff line
@@ -1702,14 +1702,11 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev, 
			}

			break;

		case CMD_ENTER_MODE:

			if (adev && pdev) {

				typec_altmode_update_active(pdev, true);

			if (adev && pdev)

				*adev_action = ADEV_QUEUE_VDM_SEND_EXIT_MODE_ON_FAIL;

			}

			return 0;

		case CMD_EXIT_MODE:

			if (adev && pdev) {

				typec_altmode_update_active(pdev, false);

				/* Back to USB Operation */

				*adev_action = ADEV_NOTIFY_USB_AND_QUEUE_VDM;

				return 0;