Commit 9e680e08 authored by Jian Shen's avatar Jian Shen Committed by Jiantao Xiao
Browse files

net: hns3: add input parameters checking 

driver inclusion
category: cleanup
bugzilla: https://gitee.com/openeuler/kernel/issues/I8M1F3


CVE: NA

----------------------------------------------------------------------

There are several driver APIs missed to validate the
input parameters, which may cause security risk. So
fixes it.

Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Signed-off-by: default avatarJiantao Xiao <xiaojiantao1@h-partners.com>
parent 7be26f9c

drivers/net/ethernet/hisilicon/hns3/hns3_ext.c

+15 −11
Original line number Diff line number Diff line
@@ -34,14 +34,14 @@ static int nic_invoke_pri_ops(struct net_device *ndev, int opcode, 
	struct hnae3_handle *h;

	int ret;



	if (nic_netdev_match_check(ndev))

		return -ENODEV;



	if ((!data && length) || (data && !length)) {

		netdev_err(ndev, "failed to check data and length");

		return -EINVAL;

	}



	if (nic_netdev_match_check(ndev))

		return -ENODEV;



	h = hns3_get_handle(ndev);

	if (!h->ae_algo->ops->priv_ops)

		return -EOPNOTSUPP;
@@ -58,6 +58,9 @@ static int nic_invoke_pri_ops(struct net_device *ndev, int opcode, 
void nic_chip_recover_handler(struct net_device *ndev,

			      enum hnae3_event_type_custom event_t)

{

	if (nic_netdev_match_check(ndev))

		return;



	dev_info(&ndev->dev, "reset type is %d!!\n", event_t);



	if (event_t == HNAE3_PPU_POISON_CUSTOM)
@@ -100,8 +103,7 @@ int nic_set_pfc_storm_para(struct net_device *ndev, int dir, int enable, 


	if (nic_check_pfc_storm_para(dir, enable, period_ms, times,

				     recovery_period_ms)) {

		dev_err(&ndev->dev,

			"set pfc storm para failed because invalid input param.\n");

		pr_err("set pfc storm para failed because invalid input param.\n");

		return -EINVAL;

	}
@@ -125,8 +127,7 @@ int nic_get_pfc_storm_para(struct net_device *ndev, int dir, int *enable, 
	if (!enable || !period_ms || !times || !recovery_period_ms ||

	    (dir != HNS3_PFC_STORM_PARA_DIR_RX &&

	     dir != HNS3_PFC_STORM_PARA_DIR_TX)) {

		dev_err(&ndev->dev,

			"get pfc storm para failed because invalid input param.\n");

		pr_err("get pfc storm para failed because invalid input param.\n");

		return -EINVAL;

	}
@@ -183,6 +184,9 @@ int nic_clean_stats64(struct net_device *ndev, struct rtnl_link_stats64 *stats) 
	struct hnae3_handle *h;

	int i, ret;



	if (nic_netdev_match_check(ndev))

		return -ENODEV;



	priv = netdev_priv(ndev);

	h = hns3_get_handle(ndev);

	kinfo = &h->kinfo;
@@ -222,15 +226,15 @@ int nic_set_cpu_affinity(struct net_device *ndev, cpumask_t *affinity_mask) 
	int ret = 0;

	u16 i;



	if (!ndev || !affinity_mask) {

	if (nic_netdev_match_check(ndev))

		return -ENODEV;



	if (!affinity_mask) {

		netdev_err(ndev,

			   "Invalid input param when set ethernet cpu affinity\n");

		return -EINVAL;

	}



	if (nic_netdev_match_check(ndev))

		return -ENODEV;



	priv = netdev_priv(ndev);

	rtnl_lock();

	if (!test_bit(HNS3_NIC_STATE_INITED, &priv->state) ||