Commit 9e395550 authored by Nicolas Palix's avatar Nicolas Palix Committed by Michal Marek
Browse files

Coccinelle: Cleanup the setting of the FLAGS and OPTIONS variables 



The FLAGS variable is factorized independently of the ONLINE mode.
The OPTIONS variable is now based on LINUXINCLUDE and explicit
includes are thus removed.

The format of the -I option differs between gcc and spatch.
The COCCIINCLUDE is used to adapt the format. This rewritting
needs bash.

Signed-off-by: default avatarNicolas Palix <nicolas.palix@imag.fr>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent 35d88a38

scripts/coccicheck

+13 −12
Original line number Diff line number Diff line 
#!/bin/sh

#!/bin/bash



SPATCH="`which ${SPATCH:=spatch}`"
@@ -11,24 +11,25 @@ else 
	VERBOSE=0

fi



FLAGS="-very_quiet"



# spatch only allows include directories with the syntax "-I include"

# while gcc also allows "-Iinclude" and "-include include"

COCCIINCLUDE=${LINUXINCLUDE//-I/-I }

COCCIINCLUDE=${COCCIINCLUDE//-include/-I}



if [ "$C" = "1" -o "$C" = "2" ]; then

    ONLINE=1



# This requires Coccinelle >= 0.2.3

#    FLAGS="-ignore_unknown_options -very_quiet"

#    OPTIONS=$*



# Workaround for Coccinelle < 0.2.3

	FLAGS="-I $srctree/include -very_quiet"

    # Take only the last argument, which is the C file to test

    shift $(( $# - 1 ))

	OPTIONS=$1

    OPTIONS="$COCCIINCLUDE $1"

else

    ONLINE=0

    FLAGS="-very_quiet"

    if [ "$KBUILD_EXTMOD" = "" ] ; then

        OPTIONS="-dir $srctree"

        OPTIONS="-dir $srctree $COCCIINCLUDE"

    else

        OPTIONS="-dir $KBUILD_EXTMOD -patch $srctree -I $srctree/include -I $KBUILD_EXTMOD/include"

        OPTIONS="-dir $KBUILD_EXTMOD -patch $srctree $COCCIINCLUDE"

    fi

fi