Unverified Commit 9e1339f3 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!8684 tcp: properly terminate timers for kernel sockets 

Merge Pull Request from: @ci-robot 
 
PR sync from: Liu Jian <liujian56@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/LWLICPRIRUTNN5CU6DSB6ZYHJWQTDLXH/ 
 
https://gitee.com/src-openeuler/kernel/issues/I9QG5Z 
 
Link:https://gitee.com/openeuler/kernel/pulls/8684

 

Reviewed-by: default avatarYue Haibing <yuehaibing@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parents d6a9ab64 8c92b5d0

include/net/inet_connection_sock.h

+1 −0
Original line number Diff line number Diff line
@@ -177,6 +177,7 @@ void inet_csk_init_xmit_timers(struct sock *sk, 
			       void (*delack_handler)(struct timer_list *),

			       void (*keepalive_handler)(struct timer_list *));

void inet_csk_clear_xmit_timers(struct sock *sk);

void inet_csk_clear_xmit_timers_sync(struct sock *sk);



static inline void inet_csk_schedule_ack(struct sock *sk)

{

include/net/sock.h

+7 −0
Original line number Diff line number Diff line
@@ -1718,6 +1718,13 @@ static inline void sock_owned_by_me(const struct sock *sk) 
#endif

}



static inline void sock_not_owned_by_me(const struct sock *sk)

{

#ifdef CONFIG_LOCKDEP

	WARN_ON_ONCE(lockdep_sock_is_held(sk) && debug_locks);

#endif

}



static inline bool sock_owned_by_user(const struct sock *sk)

{

	sock_owned_by_me(sk);

net/ipv4/inet_connection_sock.c

+14 −0
Original line number Diff line number Diff line
@@ -580,6 +580,20 @@ void inet_csk_clear_xmit_timers(struct sock *sk) 
}

EXPORT_SYMBOL(inet_csk_clear_xmit_timers);



void inet_csk_clear_xmit_timers_sync(struct sock *sk)

{

	struct inet_connection_sock *icsk = inet_csk(sk);



	/* ongoing timer handlers need to acquire socket lock. */

	sock_not_owned_by_me(sk);



	icsk->icsk_pending = icsk->icsk_ack.pending = 0;



	sk_stop_timer_sync(sk, &icsk->icsk_retransmit_timer);

	sk_stop_timer_sync(sk, &icsk->icsk_delack_timer);

	sk_stop_timer_sync(sk, &sk->sk_timer);

}



void inet_csk_delete_keepalive_timer(struct sock *sk)

{

	sk_stop_timer(sk, &sk->sk_timer);

net/ipv4/tcp.c

+2 −0
Original line number Diff line number Diff line
@@ -2751,6 +2751,8 @@ void tcp_close(struct sock *sk, long timeout) 
	lock_sock(sk);

	__tcp_close(sk, timeout);

	release_sock(sk);

	if (!sk->sk_net_refcnt)

		inet_csk_clear_xmit_timers_sync(sk);

	sock_put(sk);

}

EXPORT_SYMBOL(tcp_close);